Prepare code for breaking change in Protobuf C++ API. #178
+17
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/674897690
branch
from
956a6cc to
d3130e3
Compare
Protobuf 6.30.0 will change the return types of `Descriptor::name()` and other methods to `absl::string_view`. This makes the code work both before and after such a change. PiperOrigin-RevId: 675328307
copybara-service
bot
force-pushed
the
cl/674897690
branch
from
d3130e3 to
a785848
Compare
|
FYI Protobuf latest release is v28.1 which is wrapped as:
So I suppose 6.30.0 refer to python semantic versionning ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare code for breaking change in Protobuf C++ API.
Protobuf 6.30.0 will change the return types of
Descriptor::name()and other methods toabsl::string_view. This makes the code work both before and after such a change.