Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Annealed Importance Sampling #550
base: develop
Are you sure you want to change the base?
Adds Annealed Importance Sampling #550
Changes from 2 commits
d11c8cf
5b9974b
96a26f8
7bc1000
4f45591
c5eef05
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 455 in pybop/parameters/priors.py
Codecov / codecov/patch
pybop/parameters/priors.py#L454-L455
Check warning on line 461 in pybop/parameters/priors.py
Codecov / codecov/patch
pybop/parameters/priors.py#L458-L461
Check warning on line 466 in pybop/parameters/priors.py
Codecov / codecov/patch
pybop/parameters/priors.py#L463-L466
Check warning on line 28 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L27-L28
Check warning on line 31 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L31
Check warning on line 34 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L34
Check warning on line 39 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L39
Check warning on line 45 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L45
Check warning on line 47 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L47
Check warning on line 52 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L52
Check warning on line 61 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L57-L61
Check warning on line 66 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L66
Check warning on line 75 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L70-L75
Check warning on line 88 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L87-L88
Check warning on line 92 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L90-L92
Check warning on line 96 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L94-L96
Check warning on line 100 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L98-L100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, log_density_previous[0] should be
f_{1}(x_0)
from eqn 11Check warning on line 104 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L103-L104
Check warning on line 108 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L107-L108
Check warning on line 111 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L111
Check warning on line 115 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L114-L115
Check warning on line 118 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L118
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the gaussian test case they use in the paper, a much more complicated transition
T_j
is used, a sequence of 3 metropolis tests repeated 5-10 times. I'm not sure if all that is neccessary howeverCheck warning on line 122 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L120-L122
Check warning on line 124 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L124
Check warning on line 127 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L127
Check warning on line 130 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L130
Check warning on line 134 in pybop/samplers/annealed_importance.py
Codecov / codecov/patch
pybop/samplers/annealed_importance.py#L133-L134