Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flit instead of setuptools for vectors #10174

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Use flit instead of setuptools for vectors #10174

merged 1 commit into from
Jan 15, 2024

Conversation

alex
Copy link
Member

@alex alex commented Jan 13, 2024

Its much faster

@reaperhulk
Copy link
Member

Do we need to modify the build requirements pins for this for when we build and publish?

@alex
Copy link
Member Author

alex commented Jan 14, 2024

Hmm, it seems like we should need to, but nothing is failing?

@alex
Copy link
Member Author

alex commented Jan 14, 2024

Yeah, looks like it's not required.

@alex
Copy link
Member Author

alex commented Jan 14, 2024

build-requirements.txt isn't used when we build the sdists, and that's the only place we do anything with vectors.

@reaperhulk reaperhulk merged commit 0f69ce5 into pyca:main Jan 15, 2024
89 checks passed
@alex alex deleted the flit-vectors branch January 15, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperhulk reaperhulk reaperhulk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex @reaperhulk