Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply a refurb suggestion #10935

Closed
wants to merge 1 commit into from
Closed

Apply a refurb suggestion #10935

wants to merge 1 commit into from

Conversation

DimitriPapadopoulos
Copy link
Contributor 

FURB110 Replace ternary `if` expression with `or` operator

@DimitriPapadopoulos
Apply ruff/refurb rule FURB110
7bf6432 
	FURB110 Replace ternary `if` expression with `or` operator
alex
alex requested changes May 5, 2024
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like an improvement to me, in general explicit ternary is more readable than or.

@alex alex closed this May 5, 2024
@DimitriPapadopoulos DimitriPapadopoulos deleted the FURB branch May 5, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex alex requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @alex