src, tests: add max_chain_depth to validation API #9844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
alex
reviewed
Nov 9, 2023
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
alex
reviewed
Nov 9, 2023
| Self { | ||
| _ops: ops, | ||
| max_chain_depth: 8, | ||
| max_chain_depth: max_chain_depth.unwrap_or(8), |
There was a problem hiding this comment.
8 should be a constant with an explanation of why
Signed-off-by: William Woodruff <[email protected]>
alex
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
max_chain_depthto the Python API, and plumbs it through to the equivalent (previously invariant) setting on the Rust API. It's needed to get the last bit of coverage on #8873, since we'd otherwise be unable to exercise the corresponding Limbo testcases from Python.Breakout from #8873.