Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions: generalize the wycheproof fetch action #9848

Merged
merged 3 commits into from
Nov 10, 2023
Merged

actions: generalize the wycheproof fetch action #9848

merged 3 commits into from
Nov 10, 2023

Conversation

woodruffw
Copy link
Contributor

Not hooked up to anything yet. I'll do the actual hookup as part of #8873, since I won't be able to get coverage without it.

@woodruffw
actions: add a fetch-limbo action
c0ec72f 
Not hooked up to anything yet.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw
Copy link
Contributor Author

CI failure looks like a flake.

alex
alex reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a new action can you generalize the wycheproof one

@woodruffw
actions: combined vector fetching
4f84381 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
Copy link
Contributor Author

Instead of a new action can you generalize the wycheproof one

Done and renamed to fetch-vectors.

@woodruffw woodruffw changed the title actions: add a fetch-limbo action actions: generalize the wycheproof fetch action Nov 10, 2023
alex
alex reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update .github/dependabot.yml as well

@woodruffw
dependabot: change ref
a8db0e0 
Signed-off-by: William Woodruff <[email protected]>
@alex alex enabled auto-merge (squash) November 10, 2023 15:33
@alex alex merged commit b7096f7 into pyca:main Nov 10, 2023
55 checks passed
@woodruffw woodruffw deleted the tob-generic-fetch-vectors branch November 10, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex alex approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woodruffw @alex