Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test when running offline #1261

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix failing test when running offline #1261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ Changes:
- Changed ``OpenSSL.crypto.X509Store.add_crl`` to also accept
``cryptography``'s ``X509.CertificateRevocationList`` arguments in addition
to the now deprecated ``OpenSSL.crypto.CRL`` arguments.
- Fixed ``test_set_default_verify_paths`` test so that it is skipped if no
network connection is available.

23.2.0 (2023-05-30)
-------------------
Expand Down
6 changes: 5 additions & 1 deletion tests/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
AF_INET6,
MSG_PEEK,
SHUT_RDWR,
gaierror,
socket,
)
from sys import getfilesystemencoding, platform
Expand Down Expand Up @@ -1269,7 +1270,10 @@ def test_set_default_verify_paths(self):
)

client = socket_any_family()
client.connect(("encrypted.google.com", 443))
try:
client.connect(("encrypted.google.com", 443))
except gaierror:
pytest.skip("cannot connect to encrypted.google.com")
clientSSL = Connection(context, client)
clientSSL.set_connect_state()
clientSSL.set_tlsext_host_name(b"encrypted.google.com")
Expand Down