Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER in calling OpenSSL #1287

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER in calling OpenSSL #1287

wants to merge 2 commits into from
+25 −9

Commits on Jan 28, 2024

  1. Fix for problem caused by SSL_WANT_READ or SSL_WANT_WRITE errors. 

    When SSL_WANT_READ or SSL_WANT_WRITE are encountered, it's typical to retry the call but this must be repeated with the exact same arguments. Without this change, openSSL requires that the address of the buffer passed is the same. However, buffers in python can change location in some circumstances which cause the retry to fail.  By add the setting SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER, the requirement for the same buffer address is forgiven and the retry has a better chance of success.  See cherrypy/cheroot#245 for discussion.
    @julianz-
    julianz- committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    23e9e11 View commit details
    Browse the repository at this point in the history

  2. Removed check that is redundant with higher version of cryptography

    @julianz-
    julianz- authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    2e91054 View commit details
    Browse the repository at this point in the history