SSL_CTX_set_ciphersuites for tlsv1.3 context #1292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyGLW
force-pushed
the
main
branch
8 times, most recently
from
38269ba
to
6a15b4d
Compare
BillyGLW
changed the title
jlaine
reviewed
Jun 24, 2024
src/OpenSSL/SSL.py
Outdated
| @@ -1320,6 +1320,26 @@ def set_tmp_ecdh(self, curve): | |||
| """ | |||
| _lib.SSL_CTX_set_tmp_ecdh(self._context, curve._to_EC_KEY()) | |||
|
|
|||
| def set_ciphersuites(self, cipher_list): | |||
There was a problem hiding this comment.
def set_ciphersuites(self, cipher_list: bytes) -> None :)
|
Isn't it a bit unusual to hijack the test of another method, just because the two methods require bytes as input? |
for me it would make more sense if there would be additional test that calls both of these methods simultaneously (as it is intended), so that parametrized ones can test it individually based on bytes input and context that changes (or raises exception due to typerror).. but it also require |
BillyGLW
force-pushed
the
main
branch
3 times, most recently
from
4998df7
to
f84b711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking: #1224
As cffi binding allows to use SSL_CTX_set_ciphersuites - adaptation for setting the ciphers in context of TLSv1.3 can be made.