Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong tox env for packaging after rename in 39d89ef2 #1918

Closed
wants to merge 1 commit into from

Conversation

wulmer
Copy link
Contributor

@wulmer wulmer commented Nov 8, 2024

Hi, this PR fixes the wrong tox env name (which was not renamed with the rest of 39d89ef) and which led to the latest release packaging failures, e.g. https://github.com/pycontribs/jira/actions/runs/11516626042

@wulmer
Copy link
Contributor Author

wulmer commented Nov 8, 2024

Hi @ssbarnea , one of the checks is failing, probably due to missing access permissions for my user to the required ACTIONS_ID_TOKEN_REQUEST_URL variable.

I hope that everything else is fine.

@studioj studioj self-assigned this Nov 21, 2024
@studioj
Copy link
Collaborator

studioj commented Nov 21, 2024

@wulmer i dont have the rights either to pass this check, I'll try if i can get your commit and cherry pick it to a branch. If i cant i'll mention you in the commit message, thanks for the contribution

@adehad
Copy link
Contributor

adehad commented Nov 22, 2024

Thank you for this contribution, merged as per #1924 where the access tokens are set correctly to test.

@adehad adehad closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants