Add support for Just task runner #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hyperupcall I hope you will push some fixes on this branch. I send you and invite to allow you to do that. |
|
@ssbarnea Will do! I'll get to it later today |
|
I updated the code to be more aligned with the changes from #142 and #120. Were those the changes you were looking for in particular? I can take another look at updating the tests to improve codecov, but it will be a bit more difficult / take more time for me as there doesn't seem to be any existing tests for things in |
gotmax23
reviewed
Feb 1, 2024
| actions = [] | ||
| if not self.justfile: | ||
| msg = "Justfile not found" | ||
| raise RuntimeError(msg) |
There was a problem hiding this comment.
@ssbarnea, doesn't the CLI code have a better way to handle errors than raising a generic Exception?
| # Current implementation assumes that descriptions are added | ||
| # using double ## after the target name. | ||
| # Inspired by https://github.com/containers/podman/blob/master/Makefile#L127 | ||
| match = re.match(r"^([a-zA-Z_-]+):.*?## (.*)$$", line) |
There was a problem hiding this comment.
Can this regex be made a top level constant and re.compile()ed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.