Merge branch 'main' into fix-100

.github/workflows/release.yml

@@ -27,7 +27,7 @@ jobs:
         run: python3 -m pip install --user tox
 
       - name: Check out src from Git
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0 # needed by setuptools-scm
 

.github/workflows/tox.yml

@@ -29,7 +29,7 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check out code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 

.pre-commit-config.yaml

@@ -5,16 +5,16 @@ exclude: |
     )
 repos:
   - repo: https://github.com/PyCQA/isort
-    rev: 5.12.0
+    rev: 5.13.2
     hooks:
       - id: isort
   - repo: https://github.com/psf/black
-    rev: 23.3.0
+    rev: 24.2.0
     hooks:
       - id: black
         language_version: python3
   - repo: https://github.com/pre-commit/pre-commit-hooks.git
-    rev: v4.4.0
+    rev: v4.5.0
     hooks:
       - id: end-of-file-fixer
       - id: trailing-whitespace
@@ -25,7 +25,7 @@ repos:
       - id: debug-statements
         language_version: python3
   - repo: https://github.com/pycqa/flake8.git
-    rev: 6.0.0
+    rev: 7.0.0
     hooks:
       - id: flake8
         additional_dependencies:
@@ -35,14 +35,14 @@ repos:
           - pydocstyle>=5.1.1
         language_version: python3
   - repo: https://github.com/adrienverge/yamllint.git
-    rev: v1.32.0
+    rev: v1.35.1
     hooks:
       - id: yamllint
         files: \.(yaml|yml)$
         types: [file, yaml]
         entry: yamllint --strict
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.3.0
+    rev: v1.8.0
     hooks:
       - id: mypy
         # empty args needed in order to match mypy cli behavior
@@ -53,7 +53,7 @@ repos:
           - pytest>=6.1.2
           - enrich>=1.2.5
   - repo: https://github.com/PyCQA/pylint
-    rev: v3.0.3
+    rev: v3.1.0
     hooks:
       - id: pylint
         additional_dependencies:

Dockerfile

@@ -16,12 +16,13 @@ py3-ruamel.yaml \
 
 RUN \
 apk add --update --no-cache \
-${BUILD_DEPS} && \
-pip3 install -U pip
+${BUILD_DEPS}
 
 COPY . /root/code/
 WORKDIR /root/code/
 RUN \
 python3 --version && \
+python3 -m venv venv && \
+. venv/bin/activate && \
 python3 -m pip install ".[test]" && \
 python3 -m pytest

molecule/default/molecule.yml

@@ -2,7 +2,7 @@
 dependency:
   name: galaxy
 driver:
-  name: delegated
+  name: default
 platforms:
   - name: instance
 provisioner:

readthedocs.yml

@@ -9,7 +9,6 @@ build:
     python: "3.11"
 
 python:
-  system_packages: false
   install:
     - method: pip
       path: .

src/subprocess_tee/__init__.py

@@ -1,4 +1,5 @@
 """tee like run implementation."""
+
 import asyncio
 import os
 import platform

test/test_func.py

@@ -1,7 +1,14 @@
 """Functional tests for subprocess-tee library."""
+
 import subprocess
+import sys
+
+import pytest
 
 
+@pytest.mark.skipif(
+    sys.version_info < (3, 9), reason="molecule test requires python 3.9+"
+)
 def test_molecule() -> None:
     """Ensures molecule does display output of its subprocesses."""
     result = subprocess.run(

test/test_rich.py

@@ -1,4 +1,5 @@
 """Tests for rich module."""
+
 import sys
 
 import pytest

test/test_unit.py

@@ -1,4 +1,5 @@
 """Unittests."""
+
 import subprocess
 import sys
 from typing import Dict
@@ -148,3 +149,10 @@ def test_run_compat() -> None:
     assert ours.stdout == original.stdout
     assert ours.stderr == original.stderr
     assert ours.args == original.args
+
+
+def test_run_waits_for_completion(tmp_path):
+    """run() should always wait for the process to complete."""
+    tmpfile = tmp_path / "output.txt"
+    run(f"sleep 0.1 && echo 42 > {str(tmpfile)}")
+    assert tmpfile.read_text() == "42\n"

tox.ini

@@ -25,7 +25,8 @@ passenv =
     TERM
 setenv =
     PIP_DISABLE_VERSION_CHECK=1
-    PYTEST_REQPASS=15
+    PYTEST_REQPASS=16
+    py38: PYTEST_REQPASS=15
     PYTHONDONTWRITEBYTECODE=1
     PYTHONUNBUFFERED=1
 commands =