Skip to content

Commit

Permalink
Mention commits not included in draft release (#20)
Browse files Browse the repository at this point in the history
  • Loading branch information
ssbarnea authored Aug 23, 2020
1 parent c81826d commit a94462c
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
disable =
bad-continuation, # https://github.com/PyCQA/pylint/issues/2944
fixme,
# TODO(ssbarnea): remove temporary skips adding during initial adoption:
# TODO(ssbarnea): remove temporary skips added to speedup initial prototyping:
import-error,
missing-class-docstring,
missing-function-docstring,
missing-module-docstring,
too-few-public-methods,
too-many-branches,
too-many-locals,
wrong-import-order,
14 changes: 13 additions & 1 deletion tender/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -262,13 +262,16 @@ def do_draft(self):
)
else:
self.errors.append(
"%s containes unknown labels %s, add one required labels %s."
"%s contains unknown labels %s, add one required labels %s."
% (
link(pull.html_url, "PR #{}".format(pull.number)),
labels,
self.required_labels,
)
)
# remove processed commit from commits
del commits[pull.merge_commit_sha]

elif pull.closed_at > no_older_than:
print(pull.closed_at, no_older_than)
_logger.warning(
Expand All @@ -283,6 +286,15 @@ def do_draft(self):
)
break

# All commits for which we were not able to find a PR, likely direct pushes
for sha in commits:
commit = self.repo.get_commit(sha)
_logger.info(
"Commit '%s' not included. See %s",
commit.commit.message,
commit.html_url,
)

for section, content in sections.items():
if content:
body += f"### {section}\n\n{content}\n"
Expand Down

0 comments on commit a94462c

Please sign in to comment.