Debug accuracy issue #8443
Closed
Debug accuracy issue #8443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
force-pushed
the
akihironitta-patch-1
branch
from
86ca7e7 to
d335f06
Compare
akihironitta
force-pushed
the
akihironitta-patch-1
branch
from
37343ca to
f8de99b
Compare
akihironitta
commented
Dec 1, 2023
There was a problem hiding this comment.
Closing this for now until there's any progress in pytorch/pytorch#114109.
akihironitta
commented
Dec 6, 2023
Comment on lines
+119
to
+124
| @torch._dynamo.optimize() | ||
| def _scatter_min_or_max(src: Tensor, index: Tensor, dim: int, size: int, | ||
| reduce: str): | ||
| return src.new_zeros(size).scatter_reduce_(dim, index, src, | ||
| reduce=f'a{reduce}', | ||
| include_self=False) |
There was a problem hiding this comment.
@rusty1s Disabling compiling this part of the computation will address the accuracy issue.
There was a problem hiding this comment.
Or, in other words, enabling compiling this computation will cause the accuracy issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.