Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added log_softmax to utils with tests #8909

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

elilaird
Copy link

Add log_softmax for Sparse Tensors in torch_geometric

  • Implements log_softmax function for numerical stability in GNNs
  • Includes comprehensive tests for correctness and backward compatibility
  • Benchmarks performance against PyTorch's built-in log_softmax
  • Detailed documentation

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.85%. Comparing base (dafbd30) to head (c48cbe9).
Report is 12 commits behind head on master.

Current head c48cbe9 differs from pull request most recent head f88f0d3

Please upload reports for the commit f88f0d3 to get more accurate results.

Files Patch % Lines
torch_geometric/typing.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8909      +/-   ##
==========================================
- Coverage   88.25%   86.85%   -1.41%     
==========================================
  Files         473      463      -10     
  Lines       30844    30569     -275     
==========================================
- Hits        27221    26550     -671     
- Misses       3623     4019     +396     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elilaird
Copy link
Author

elilaird commented Mar 1, 2024

Ready for merge/review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants