-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLM-Enhanced Text-Attributed Graph (TAG) Representation Learning #9428
Conversation
from vllm import LLM, SamplingParams | ||
|
||
|
||
class LlmOfflineEngine(LlmEngine): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some overlap with Rishi's current work on adding G-Retriever: #9462
It would be nice to keep the LLM models in a specific directory, as it was done by Rishi in the above PR.
+@puririshi98 for further insights
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i definitely agree here. as it stands this pr is basicaly the equivalent of making your own research repository on github and using PyG. there is no integration into the actual framework. there are 32 changed files which is far too much to effectively review at once. For adding G-retriever I have broken my PR down into smaller PRs first. however before embarking on that I recommend you understand how your work could actualy be integrated into torch_geometric itself, rather than just what is essentially a standalone example repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Kh4L and @puririshi98, for your feedback.
@puririshi98, I agree with you. There is no integration into the actual framework; hence, it is under the examples
directory. The proposed TAPE method converts title/abstract text into LLM responses (prediction and explanation) into node features and uses it to train respective GNN models and combine the result of each GNN model. I have created a repository extending this method: tag-llm.
@rusty1s, how would you like to move forward with this since you proposed it?
in my opinion this PR is not mergeable as is. as it stands this is basically just a seperate github repository that you are trying to paste into the examples folder. if you would like to get work on TAPE submitted, please looks at this work there is also nobody working on the InstructMol task of the community sprint if you would rather contribute to that: |
PR for #9361.
I have skipped the
Design Choices
section from the README. You can find theDesign Choices
section here. I can include it if necessary.Please let me know if any changes are required.
Pre-commit Issue
Due to the pre-commit configuration for the
torch_geometric
package, the isort hook removes the newline between the external library imports and thetape
package library imports. For example, in train.py:It also disrupts the order of imports. For example, in gnn_trainer.py: