Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS224W: TransH model implementation for KGE #9868

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

cjiang-git
Copy link

@cjiang-git cjiang-git commented Dec 15, 2024

TransH

  1. Implemented transH from "Knowledge Graph Embedding by Translating on Hyperplanes" from (https://aaai.org/papers/8870-knowledge-graph-embedding-by-translating-on-hyperplanes/) using inbuilt KGEModel. Some code inspired from (https://github.com/thunlp/TensorFlow-TransX/blob/master/transH.py)
  2. Kept model architecture/comments similar to existing rotate/transE files to ensure codebase consistency. Comments based after transE comments but modified for transH (including functions)
  3. modified code to include transH in testing

not part of main project (my main was project 1)

Flake8 passed
pytest --cov passed
changelog modified

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (2b1b327) to head (6412d5a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9868      +/-   ##
==========================================
+ Coverage   85.63%   86.33%   +0.69%     
==========================================
  Files         478      491      +13     
  Lines       31925    32320     +395     
==========================================
+ Hits        27339    27902     +563     
+ Misses       4586     4418     -168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant