Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GKAN #9870

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

danielshin1
Copy link

@danielshin1 danielshin1 commented Dec 15, 2024

Added GKAN: Graph Kolmogorov-Arnold Networks as introduced in paper by Mehrdad Kiamari, and Bhaskar Krishnamachari. and the Kolmogorov-Arnold Network comes from the work https://arxiv.org/pdf/2404.19756 and implementation of kan is here https://github.com/KindXiaoming/pykan.

@puririshi98
Copy link
Contributor

puririshi98 commented Dec 17, 2024

@danielshin1 do you have any experiments showing that this model outperforms existing GNNs?
It would make it much easier for me to merge this if you could test this model on papers100
https://github.com/pyg-team/pytorch_geometric/blob/1157d80b6926b9772c51cd73386ad72315194c20/examples/ogbn_train_scheduler.py
see this example which will soon be merged into main branch. if you can copy this code and add your GKAN model to it and name the new file ogbn_train_kolmogorov_arnolds.py. if you can produce significant lift over the this would be a better example to have than the CORA example which is basiclly toy data.
I am very interesting in this work and had been wondering how KAN effects GNNs. I look forward to the results and working with you to get this merged in

@puririshi98 puririshi98 self-requested a review December 17, 2024 23:02
@puririshi98
Copy link
Contributor

also try to get the Ci to be all green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants