-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Polynormer
model and example
#9908
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…ic into models/polynormer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9908 +/- ##
==========================================
- Coverage 86.56% 86.30% -0.26%
==========================================
Files 490 491 +1
Lines 32294 32335 +41
==========================================
- Hits 27954 27907 -47
- Misses 4340 4428 +88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please share a log of running the example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please put the Model from example into torch_geometric.nn.models
then also put a unit test under test/nn/models.
then please integrate the model into examples/ogbn_train.py.
do this with "--gnn-choice" arg parse option, with choices ["sage, gat, polynormer_graph_transformer"]
please share the log of all 3 and then change the default to the best
(i will have other PRs for GraphTrasnformers follow this design pattern so its unified)
Issue
Usage
python examples/polynormer.py --post_bn
Highlight
Result