Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative_sampling leading to runtime error because of zero sample size #9957

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix negative_sampling leading to runtime error because of zero sample size #9957

wants to merge 4 commits into from

Conversation

erytheis
Copy link
Contributor

Fixes negative_sampling leading to runtime error when the sample_size is 0 (for example when only 1 undirected edge is sampled #9709 )

@erytheis erytheis requested a review from wsad1 as a code owner January 17, 2025 11:20
akihironitta
akihironitta reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a test case to cover what's being fixed?

@erytheis erytheis requested a review from akihironitta January 21, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@akihironitta akihironitta Awaiting requested review from akihironitta

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erytheis @akihironitta