Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese-br Translation readme and tutorials #2845

Conversation

Gabryel-lima
Copy link

@Gabryel-lima Gabryel-lima commented May 9, 2024

Issues: #2719
Branch removed: #2720

@Starbuck5

I made the missing adjustments. In any case, I am at your disposal for further adjustments.

@Gabryel-lima Gabryel-lima requested a review from a team as a code owner May 9, 2024 16:43
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

First of all, thanks for contributing!

AFAICT we don't have any active reviewers fluent in Portuguese-br, so this PR may take a while to review. Maybe we could ask around on the discord server if anyone is willing to review the translations.

@Gabryel-lima
Copy link
Author

Hello,

First of all, thanks for contributing!

AFAICT we don't have any active reviewers fluent in Portuguese-br, so this PR may take a while to review. Maybe we could ask around on the discord server if anyone is willing to review the translations.

No problem! I appreciate it. I'm happy to be contributing in some way. @Starbuck5 was very patient with me too lol!

@MyreMylar
Copy link
Member

Related: #2871

@MyreMylar
Copy link
Member

I think you'll need to merge with main again now that the images have moved and then change the paths and remove your additional copies of them.

@Gabryel-lima
Copy link
Author

I think you'll need to merge with main again now that the images have moved and then change the paths and remove your additional copies of them.

I'll do this!

@Gabryel-lima Gabryel-lima requested a review from a team as a code owner May 25, 2024 19:29
@MyreMylar
Copy link
Member

How do you access these new tutorials as a user from the docs?

Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking this through more and I'm not sure we should do it at all.

The tutorials are already outdated, it'll be worse when we have different language versions out of sync and impossible for the contributors to effectively keep going.

I also would like to rewrite the README, so the translation of that will also be obsolete quickly.

I appreciate the effort from Gabryel, but I'm a -1 on merging this.

@Gabryel-lima
Copy link
Author

How do you access these new tutorials as a user from the docs?

It would be more for the README.

I've been thinking this through more and I'm not sure we should do it at all.

The tutorials are already outdated, it'll be worse when we have different language versions out of sync and impossible for the contributors to effectively keep going.

I also would like to rewrite the README, so the translation of that will also be obsolete quickly.

I appreciate the effort from Gabryel, but I'm a -1 on merging this.

All good! I understand, I'm happy to be participating in this community in some way. I won't give up until I can help in some way. thank you friends!

In any case, when changing the README. I'll give the translation based on your @Starbuck5.
Could I remove my changes and commit them back here? Or should I close this PR anyway?

@Gabryel-lima
Copy link
Author

Gabryel-lima commented May 28, 2024

I'll leave this pr closed for now. When they start migrating to sphinx, I'll follow. #2878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants