Clarify how Rect and positions relate in the intro tutorial #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
approved these changes
Sep 23, 2024
bilhox
requested changes
Sep 24, 2024
| @@ -152,7 +152,8 @@ Drawing of images is handled by the | |||
| :meth:`Surface.blit() <pygame.Surface.blit>` method. | |||
| A blit basically means copying pixel colors from one image to another. | |||
| We pass the blit method a source :class:`Surface <pygame.Surface>` | |||
| to copy from, and a position to place the source onto the destination. | |||
| to copy from, and a :class:`Rect <pygame.Rect>` object, representing | |||
There was a problem hiding this comment.
I would suggest here to stay with the old sentence. It feels more logical and intuitive to pass a destination position (which is even more used than Rects based on datas I don't have), rather than making a rect.
MyreMylar
reviewed
Oct 1, 2024
MyreMylar
reviewed
Oct 1, 2024
to hopefully clarify that while rects can be used as positions, they are not the only way to position and they also have other uses.
|
I slightly tweaked the updated wording to hopefully more clearly express what rects are and the multiple ways to position blits. |
bilhox
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction to PyGame tutorial is a bit confusing for very beginners about the
Rectobject.I think for beginners talking about a rectangular area it sounds like a rectangle will be printed on the screen. I think it's better to be more specific and mention that rectangular areas are the way to manage an object position.