Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add and modified readme for Traditional Chinese. #3113

Merged
merged 8 commits into from
Dec 31, 2024
Merged

add and modified readme for Traditional Chinese. #3113

merged 8 commits into from
Dec 31, 2024

Conversation

noahcse
Copy link
Contributor

@noahcse noahcse commented Sep 23, 2024

hi, I join PyConTW sprints pygame session, and wanna to make a traditional Chinese doc for people who use traditional Chinese to collab and enjoy fun of pygame.

@noahcse noahcse requested a review from a team as a code owner September 23, 2024 07:28
ankith26
ankith26 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Traditional Chinese, but I am approving this PR nonetheless. I did a quick check with google translate and found nothing objectionable.

Thanks for contributing! 🥳

@ankith26 ankith26 added this to the 2.5.2 milestone Sep 23, 2024
@bilhox
Copy link
Contributor

bilhox commented Sep 24, 2024

Now that japanese translation was merged, it's time to fix merge conflicts by updating your branch.
Anyways, thank you for the PR!

@yunline yunline added the docs label Sep 25, 2024
yunline
yunline previously requested changes Sep 25, 2024
View reviewed changes
docs/readmes/README.zh-tw.rst Outdated Show resolved Hide resolved
@hisa10 hisa10 mentioned this pull request Oct 10, 2024
Closed
@Starbuck5 Starbuck5 removed this from the 2.5.2 milestone Oct 13, 2024
MyreMylar
MyreMylar reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple of missed sections.

I'll check the other chinese readme PR and see if they are included.

MyreMylar
MyreMylar approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think that is the main updates and merges the two PRs.

@MyreMylar MyreMylar merged commit d69b9e2 into pygame-community:main Dec 31, 2024
1 of 2 checks passed
@ankith26 ankith26 added this to the 2.5.3 milestone Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@ankith26 ankith26 ankith26 approved these changes

@yunline yunline yunline left review comments

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.
6 participants
@noahcse @bilhox @MyreMylar @yunline @ankith26 @Starbuck5