Port key and mouse to SDL3 #3207
Conversation
| /* SDL3 changed the mouse API to deal with float coordinates, for now we | ||
| * still truncate the result to int before returning to python side. | ||
| * This can be changed in a breaking release in the future if needed. */ | ||
| float x, y; |
There was a problem hiding this comment.
So it gets it as a float, how does it get converted to an int? Because it gets passed a function that takes ints.
There was a problem hiding this comment.
Yeah that just happens implicitly, I didn't bother documenting it because I didn't think it should cause any confusion
There was a problem hiding this comment.
If you had written int ix = (int)x; I wouldn't have batted an eye. Even int ix = x; So I assume that passing to into a parameter of a type is the same as assignment?
There was a problem hiding this comment.
Yeah, true. I can make the function call
return pg_tuple_couple_from_values_int((int)x, (int)y); if that helps. It becomes more explicit but verbose
There was a problem hiding this comment.
Tbh, I'm not a fan of downcasting without explicitly checking that the value is within range of the destination data type. That just seems like a recipe for hard-to-diagnose bugs
There was a problem hiding this comment.
I think we use casts to ints from floats in other places, I don't see how we could check range elegantly. For this I think the mouse coordinates reported will be reasonable numbers.
Just following the footsteps of #3206 but separated out in a different PR because these changes are not as trivial as those