Deprecate Window foreign kwarg and Window.focus input_only kwarg
#3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
changed the title
Window foreign kwarg and Window.focus input_only kwarg
|
Also added another deprecation for the Now the only think left to address in porting |
damusss
reviewed
Nov 22, 2024
yunline
reviewed
Nov 23, 2024
There was a problem hiding this comment.
Accroding to this commit the SDL_WINDOW_FOREIGN is not removed. It's renamed to SDL_WINDOW_EXTERNAL.
However I approve to deprecate this kwarg.
In Window.__init__ we create a SDL window, However SDL_WINDOW_EXTERNAL is a flag for "window not created by SDL". Setting this kwarg doesn't make any sence.
MyreMylar
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at compiling
Windowunder SDL3, and seems likeSDL_WINDOW_FOREIGNis now gone, with no mention or a replacement in SDL3. The easiest thing to do now seems to be undocumenting, and the code now raises a deprecation warning if theforeignkwarg is received.