Fix failing tests: change Tuple[float, float] to Point in geometry.pyi
#3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddbookworm
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
LGTM! Thanks for fixing this. It's just a classic example of the PR being old enough that a change from another pull request broke something in this PR without causing a merge conflict, so CI never reran without a new pull from main or a new commit. We should probably have some kind of policy where we require a fresh pull from main on new merges? @pygame-community/pygame-contributing-admins thoughts?
damusss
added
type hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed in merged #3179 somehow.
Mypy tests are failing because
Tupleis no longer available ingeometry.pyi. It should bePointanyway.