Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loop and fade options to pygame.mixer.channel.queue() #3252

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

AntoineMamou
Copy link
Contributor

This PR is related to this issue : #3236

I added optionals argument loop and fade in chan_queue to let the user choose if he wants to play the sound in the queue with a loop or a fade effect. I also modified the callback function to play the sound with the good effect.

@AntoineMamou AntoineMamou requested a review from a team as a code owner December 5, 2024 14:09
@damusss
Copy link
Member

damusss commented Dec 5, 2024

Is my GitHub tweaking, why does this PR also add angle and angle rad properties? did you mix some branches?
Anyways, I didn't look at the code in depth but I can notice the missing mixer tests and stubs. Also the comments explaining the code should be written in English, not French, so everyone can understand them.
Also Also while the docs explain the new parameters, they have not been added to the function signature a few lines above.

@AntoineMamou
Copy link
Contributor Author

Yeah I probably mix some branch, sorry. Thanks for your comment, I'm going to change what I forgot.

@AntoineMamou
Copy link
Contributor Author

Maybe this PR should be closed, idk

@Starbuck5 Starbuck5 added New API This pull request may need extra debate as it adds a new class or function to pygame mixer.music pygame.mixer.music labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mixer.music pygame.mixer.music New API This pull request may need extra debate as it adds a new class or function to pygame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants