Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port imageext.c to SDL3(_image) #3262

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Port imageext.c to SDL3(_image) #3262

merged 1 commit into from
Dec 31, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Dec 9, 2024

With the release of the SDL3_image prerelease, we can now start testing compilation of imageext.c on our SDL3 CI. The actual code changes in this PR are rather trivial because most of the porting work has already been done in previous PRs

@ankith26 ankith26 requested a review from a team as a code owner December 9, 2024 17:57
@damusss damusss added image pygame.image sdl3 labels Dec 9, 2024
@ankith26 ankith26 force-pushed the ankith26-imageext-sdl3 branch from b8e452a to 1ba8ae3 Compare December 9, 2024 18:08
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ankith26 ankith26 force-pushed the ankith26-imageext-sdl3 branch from 1ba8ae3 to 965de32 Compare December 15, 2024 10:18
@ankith26
Copy link
Member Author

Force pushed with a merge conflict fix (and no changes apart from that)

@ankith26 ankith26 force-pushed the ankith26-imageext-sdl3 branch from 965de32 to 2973c8b Compare December 27, 2024 08:56
@MyreMylar MyreMylar closed this Dec 31, 2024
@MyreMylar MyreMylar reopened this Dec 31, 2024
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit 71d8b23 into main Dec 31, 2024
48 of 49 checks passed
@ankith26 ankith26 deleted the ankith26-imageext-sdl3 branch December 31, 2024 14:34
@ankith26 ankith26 added this to the 2.5.3 milestone Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
image pygame.image sdl3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants