Make additional/custom resources available #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to allow specification of custom resources (or other resources not currently included by default)
desilinguist
approved these changes
Apr 23, 2020
Fix up resources addition in native_specification Co-Authored-By: Nitin Madnani <[email protected]>
|
While this is finishing up CI again, I'd like to mention that I have run some non-trivial tasks using this branch today (SKLL unit tests). I'm fairly confident that it works as intended and doesn't break anything. |
|
I guess the documentation will update automatically when we merge since all we have is API documentation? |
mulhod
changed the title
|
Ok, not WIP anymore. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #88 and #89 and supersedes PR #91.
I still want to do some testing with it, so this is not ready for review.