Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update factor analysis nb to v5 #586

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

erik-werner
Copy link
Contributor

@erik-werner erik-werner commented Oct 24, 2023

Fix so that the nb doesn't crash at pm.Minibatch


📚 Documentation preview 📚: https://pymc-examples--586.org.readthedocs.build/en/586/

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@erik-werner erik-werner marked this pull request as ready for review October 24, 2023 09:48
@erik-werner
Copy link
Contributor Author

erik-werner commented Oct 24, 2023

Weird error in the CI pre-commit check:

Error: reserveCache failed: Cache already exists. Scope: refs/pull/586/merge, Key: pre-commit-2-3062ff7e79208312406649393529767a0ddbbadd6828c544993cabef7ae8f110-b70d2bc17f390a7fc1fd9e3e69c215cb25e6331d7218c479f779bcced1326092, Version: 25d34710bdd63bed70a22b8204c3e1d0942dc237e098600e3896b4334c6d784f

@erik-werner erik-werner marked this pull request as draft October 24, 2023 10:22
@erik-werner
Copy link
Contributor Author

erik-werner commented Oct 24, 2023

Reversed to draft PR as I think the sampling of F might not match the updated equation in the cell above it. I'll try to figure this out before marking it as Ready for review.

@erik-werner
Copy link
Contributor Author

This turned into a bit of a rabbit hole which I unfortunately don't have time to dive into right now. I propose to just merge in the update to v5 that fixes the crash, and then I'll write an issue for the rest of the work that I think should be done.

@erik-werner erik-werner force-pushed the update_factor_analysis branch from 8132682 to cab9eed Compare October 24, 2023 14:28
@erik-werner erik-werner marked this pull request as ready for review October 24, 2023 14:43
@erik-werner
Copy link
Contributor Author

I've added an issue here: #587.

@twiecki twiecki merged commit bed70e3 into pymc-devs:main Nov 6, 2023
1 check passed
@twiecki
Copy link
Member

twiecki commented Nov 6, 2023

This is great - thanks @erik-werner!

@erik-werner erik-werner deleted the update_factor_analysis branch November 6, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants