-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update factor analysis nb to v5 #586
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Weird error in the CI
|
Reversed to draft PR as I think the sampling of |
This turned into a bit of a rabbit hole which I unfortunately don't have time to dive into right now. I propose to just merge in the update to v5 that fixes the crash, and then I'll write an issue for the rest of the work that I think should be done. |
8132682
to
cab9eed
Compare
I've added an issue here: #587. |
This is great - thanks @erik-werner! |
Fix so that the nb doesn't crash at pm.Minibatch
📚 Documentation preview 📚: https://pymc-examples--586.org.readthedocs.build/en/586/