Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crc32c to version 2.7.1 #5169

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

agriyakhetarpal
Copy link
Member

Description

This PR bumps crc32c to the latest available version, 2.7.1. I'm updating this in accordance with zarr-developers/numcodecs#529, where we previously added this package in-tree (#4787, #4789), but they are requiring a later version now. The package has no dependencies that need to be updated or otherwise.

Checklists

@agriyakhetarpal
Copy link
Member Author

I also planned to add https://github.com/LLNL/zfp (zfpy) but they don't have a source distribution available on PyPI yet: https://pypi.org/project/zfpy/#files. It is a dependency for numcodecs, albeit not a required one (but still good enough to test for). Should I create a dummy sdist for it, or perhaps we can experiment with the GitHub tarball until I request that they publish one for the next release? Adding the package would also block #4925, though, because they don't support NumPy v2 yet (LLNL/zfp#210), but there's a chance it might just work. I'll comment on that issue about both of these aspects. In the meantime, bumping just crc32c would here should suffice for numcodecs, since it seems to be required for the test suite (the tests that use it are not skipped if it isn't available), even though it's listed as an optional dependency.

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agriyakhetarpal
Copy link
Member Author

Thanks for the review!

@agriyakhetarpal agriyakhetarpal merged commit 870a67c into pyodide:main Nov 9, 2024
5 of 9 checks passed
@agriyakhetarpal agriyakhetarpal deleted the update/numcodecs-deps branch November 9, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants