-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle venv_resolve_deps exception #6166
base: main
Are you sure you want to change the base?
Handle venv_resolve_deps exception #6166
Conversation
@sanspareilsmyn looks like a code linting error. I recommend installing |
Also, I think your change here may be better/supersede the need for: #6163 |
@matteius Thank you for noticing me. It was due to missing backtick in news fragment. I haven't read your draft PR in prior, but I think handling error in a way I suggest may be more general and runtime-safe to catch other potential corner cases! |
@matteius Hi! Do you mind if you review this PR? Thank you:) |
There are now conflicts with the code that changes -- it needs to be rebased from main. |
@matteius Conflict resolved! Thanks for the notice:) |
The issue
This is an enhancement of error message regards to #6073.
Inside
do_lock
method, exceptions invenv_resolve_deps
wasn't properly handled by far. This PR handles exception to improve this problem. Since RuntimeError raised insidevenv_resolve_deps
can't be easily modified, (it's related to so many components) it raises sys.exit(1) when RuntimeError occurs, and additional traceback log is added on general Exception.The fix
venv_resolve_deps
function.The checklist
news/
directory to describe this fix with the extension.bugfix.rst
,.feature.rst
,.behavior.rst
,.doc.rst
..vendor.rst
. or.trivial.rst
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.