Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect command reminder after installs #6199

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Fix incorrect command reminder after installs #6199

merged 4 commits into from
Jul 15, 2024

Conversation

nmagee
Copy link
Contributor

@nmagee nmagee commented Jul 10, 2024

Issue

When installing new packages using pipenv install <package> the following reminder may be returned when the Pipfile is out of date:

Pipfile.lock (<hash>) out of date: run `pipfile lock` to update to (<new-hash>)...

However, no such command pipfile lock exists. The next returned line proceeds to run the correct command for the user:

Running $ pipenv lock then $ pipenv sync.

So it appears the author actually meant the reminder message to read pipenv lock since that is what is subsequently run.

Fix

Updated line of pipenv/routines/install.py to return correct command. See here

Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Please add a news file under news/

@nmagee
Copy link
Contributor Author

nmagee commented Jul 14, 2024

@oz123 this is all set now. Thanks!

@oz123 oz123 merged commit 48e6d68 into pypa:main Jul 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants