Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue with quiet lock not writing the lock file. #6208

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

matteius
Copy link
Member

The issue

More work needs to be done to respect the quiet state across utilities, which may mean studying up on how we track command state -- I don't want to just extend all the utilities to have a quiet parameter for example. Anyway, this should fix the issue reported where quiet does not write the lock file changes.

Fixes #6207

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing news. Besides that LGTM.

@oz123 oz123 merged commit b9ef7ad into main Aug 19, 2024
2 checks passed
@oz123 oz123 deleted the issue-6207 branch August 19, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIPENV_QUIET seems to bug the lock command
2 participants