remove all click.style calls from exceptions.py #6219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
approved these changes
Aug 2, 2024
aidencullo
force-pushed
the
remove-click-style-from-exceptions
branch
from
fc75141
to
e8a932f
Compare
matteius
reviewed
Sep 23, 2024
| @@ -137,14 +137,14 @@ def show(self, file=None): | |||
|
|
|||
|
|
|||
| class PipenvFileError(FileError): | |||
| formatted_message = "{} {{}} {{}}".format(click.style("ERROR:", fg="red", bold=True)) | |||
| formatted_message = "{} {{}} {{}}".format("[bold red]ERROR:[/bold red]") | |||
There was a problem hiding this comment.
I am not sure -- does this work or does it have to be [bold][red]?
There was a problem hiding this comment.
yes it works like that, it can be either
There was a problem hiding this comment.
Ah ok thanks --sorry I accidentally marked this as ready for review -- feel free to change back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Click library is large and redundant.
The fix
replace click.style calls in:
pipenv/exceptions.py
@oz123