Disable deprecated/problematic ruff rules #1077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UP027: deprecated UP038: astral-sh/ruff#7871
|
if we don't fix/revert the changes those might have done, its less maintenance to just wait for ruff to fix the stuff with own rules later as far as i can tell we are not affected by the performance impact, and this pr doesn't change anything instead of manually searching for fixes, i'd prefer to just eventually have a ruff update fix it automatically in future |
|
It's just that I fell bad for importing these bad rules here 😄 |
|
i understand the sentiment, luckily in the grand scheme of things the impact doesn't matter as much as it feels and we can just wait it out ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UP027: deprecated
UP038: astral-sh/ruff#7871