-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt setuptools_scm #4532
base: feature/remove-self-tags
Are you sure you want to change the base?
Adopt setuptools_scm #4532
Conversation
c45e774
to
5782e2a
Compare
1b8a693
to
2faa82c
Compare
I don't understand the test failures. The tests pass for me locally. Also, the test failures seem largely unrelated to the change. The only thing I can think is that maybe the tests are somehow reliant on Setuptools' own MANIFEST.in. I'm going to sleep on it and tomorrow try to replicate the issue in a Docker image or using the |
_repair_changelog() | ||
|
||
|
||
def _repair_changelog(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does excluding this file also mean that we no longer need to repair the changelog and that #2666 is already solved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe so. I don't encounter the issue in other skeleton projects, so I assume so. If it turns out it's still a problem, I'll just strip out whatever customizations setuptools is using that introduce the bug. No reason to carry around this debt.
@@ -122,6 +122,8 @@ core = [ | |||
"platformdirs >= 2.6.2", | |||
] | |||
|
|||
[tool.setuptools_scm] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that this line gets moved, but it was already present. I'll move it back.
Summary of changes
Closes #4530
Pull Request Checklist
newsfragments/
.(See documentation for details)