Add exception for old versions of importlib_metadata
#4572
Conversation
| if not hasattr(metadata, "EntryPoints"): # pragma: no cover | ||
| raise ImportError( | ||
| "`importlib-metadata` version is incompatible with `setuptools`. " | ||
| "Please install importlib-metadata>=4.6" # Equivalent to stdlib's in 3.10 |
There was a problem hiding this comment.
The choice of importlib-metadata>=4.6 is based on the fact that the if statement above accepts stdlib's version for Python 3.10 and according to importlib_metadata's docs that is equivalent to version 4.6.
So if the codebase works with importlib.metadata in Python 3.10 it should also work with importlib_metadata 4.6. I am not sure why pyproject.toml requires importlib_metadata>=6...
There was a problem hiding this comment.
I think it was just pinned to whatever the vendored versions were when they got added as dependencies in pyproject.toml.
Here's when you bumped importlib_metadata from 4.11.1 to 6.0.0: #3832
The bump from 4.10.1 to 4.11.1 was made here: #3109 for #3107
4.10.1 was the initial pin of this vendored dependency
jaraco
changed the title
importlib_resourcesimportlib_metadata
Summary of changes
Add exception for old versions of
importlib_metadataCloses #4570
Pull Request Checklist
newsfragments/.(See documentation for details)