-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic updates from Ruff for Python 3.9+ #4721
Conversation
Idk if we want the |
57468ce
to
d2e7e70
Compare
You are right. I should, at least, separate it into to 2 PRs. I will have a look at it later, thank you. |
d2e7e70
to
3fa7d33
Compare
Removed the changes for |
This thing of |
I was surprised that Ruff didn't also move |
Perfect, thank you very much @Avasam, for the thorough review. I think from this set of PRs, the only controversial one is the one I remove the vendored copy of But we should be able to merge this PR with relatively ease. |
3fa7d33
to
e8a62df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typing looks fine and is 3.9 compatible 👍🏻
Summary of changes
Implement @Avasam suggestions from #4718 (comment):
The procedure used for the changes is:
ruff.toml
as suggested in Remove unnecessary code paths for 3.9+ (follow up onskeleton
changes) #4718 (comment)ruff check --fix --unsafe-fixes
git restore ruff.toml
(I am leaving this decision forskeleton
for the time being)git restore setuptools/_importlib.py
(Already covered in Remove unnecessary code paths for 3.9+ (follow up onskeleton
changes) #4718)Pull Request Checklist
newsfragments/
.(See documentation for details)