Merge typeshed return annotations #4744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
changed the title
Avasam
force-pushed
the
Merge-typeshed-return-annotations
branch
from
fb5487b to
aa0ad57
Compare
This was referenced Nov 19, 2024
2 tasks
Avasam
commented
Nov 20, 2024
Comment on lines
+269
to
+270
| # We shouldn't find any non-pyc files in __pycache__ | ||
| assert m is not None |
There was a problem hiding this comment.
Not strictly an annotation change, but I included it here because it didn't feel worth doing a PR just for this
Would've been included in #4753 if I realised sooner this was an easy fix
Avasam
commented
Nov 20, 2024
setuptools/command/bdist_wheel.py
Outdated
| def run(self) -> None: | ||
| def run(self): |
There was a problem hiding this comment.
I opted out of annotating this specific run in this PR for the same reason I didn't do initialize_options.
(note that I'm commenting on a specific commit, this PR doesn't remove any return annotation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Based on #4736,
so merge that one first.Donesetuptools/msvc.py dir methods and properties split off to #4755 for easier review
Step 6.2 of #2345 (comment)
This PR still doesn't do
initialize_optionsas those have their own set of issues (and knowing they returnNoneisn't that helpful to begin with), as well as complex Command-based overloads.This will produce many type issues that need to be resolved. I'll do that in other PRs and keep this as draft in the mean time.
Pull Request Checklist
newsfragments/. (not public facing yet)(See documentation for details)