Skip to content

Commit

Permalink
autorelease: remove excessive note/todo/fixme marks
Browse files Browse the repository at this point in the history
  • Loading branch information
mara004 committed Jan 18, 2024
1 parent a8c3cd3 commit 2e84994
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions setupsrc/pypdfium2_setup/autorelease.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,20 +96,16 @@ def log_changes(summary, prev_pdfium, new_pdfium, new_tag, beta):
Changelog.write_text(content)


# NOTE git add: places don't need to have been changed, git silently skips this
# NOTE tag: The actually published tag will be a different one (though with same name), but it's nevertheless convenient to have this here because of changelog and git describe
def register_changes(new_tag):
run_local(["git", "checkout", "-B", "autorelease_tmp"])
run_local(["git", "add", *PlacesToRegister])
run_local(["git", "commit", "-m", f"[autorelease main] update {new_tag}"])
# Note, the actually published tag will be a different one (though with same name), but it's nevertheless convenient to have this here because of changelog and git describe
run_local(["git", "tag", "-a", new_tag, "-m", "Autorelease"])


# FIXME takes many parameters ...
# FIXME log fails if args.register is False - skip, or use HEAD and omit ver_b ?
# TODO add GH compare link?
# TODO consider skipping URLs for pypdfium2 (GH links commits automatically) ?
def _get_log(name, url, cwd, ver_a, ver_b, prefix_ver, prefix_commit, prefix_tag):
# known issue: log fails if args.register is False
log = ""
log += "\n<details>\n"
log += f" <summary>{name} commit log</summary>\n\n"
Expand All @@ -122,10 +118,11 @@ def _get_log(name, url, cwd, ver_a, ver_b, prefix_ver, prefix_commit, prefix_tag
log += "\n\n</details>\n"
return log

# FIXME is there a faster way to get pdfium's commit log?
# TODO should we specifically show changes to public/ ?

def make_releasenotes(summary, prev_pdfium, new_pdfium, prev_tag, new_tag, c_updates):

# TODO specifically show changes to public/ ?

relnotes = ""
relnotes += f"## Changes (Release {new_tag})\n\n"
relnotes += "### Summary (pypdfium2)\n\n"
Expand Down

0 comments on commit 2e84994

Please sign in to comment.