Skip to content

Commit

Permalink
fix(tests): pin python<3.0
Browse files Browse the repository at this point in the history
With Cython 3.0, on github actions:
- All openmp tests fail on windows.
- Elliptical drop with openmp fails on ubuntu due to timeout.
- All openmp tests pass on macos runner
- test_compressed_octree_has_lesser_depth_than_octree fails

Pinning cython<3.0 to fix these failures.
  • Loading branch information
nauaneed committed Nov 28, 2023
1 parent e18af87 commit cf9fbf7
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Install dependencies
run: |
conda info
conda install -c conda-forge numpy cython h5py
conda install -c conda-forge numpy 'cython<3.0' h5py
python -m pip install --upgrade pip setuptools wheel
python -m pip install https://github.com/pypr/cyarray/zipball/master
python -m pip install https://github.com/pypr/compyle/zipball/master
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/zoltan-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Install dependencies
run: |
conda info
conda install -c conda-forge numpy cython
conda install -c conda-forge numpy 'cython<3.0'
python -m pip install --upgrade pip setuptools wheel
python -m pip install mpi4py
python -m pip install https://github.com/pypr/cyarray/zipball/master
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[build-system]
requires = [
"Beaker",
"Cython>=0.20",
"Cython<3.0",
"compyle>=0.8",
"cyarray",
"mako",
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
numpy
setuptools>=42.0.0
Cython>=0.20
Cython<3.0
cyarray
compyle>=0.8
mako
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ def setup_package():

# The requirements.
install_requires = [
'numpy', 'mako', 'cyarray', 'compyle>=0.8', 'Cython>=0.20',
'numpy', 'mako', 'cyarray', 'compyle>=0.8', 'Cython<3.0',
'setuptools>=42.0.0', 'pytools', 'Beaker'
]
tests_require = ['pytest>=3.0', 'h5py', 'vtk']
Expand Down

0 comments on commit cf9fbf7

Please sign in to comment.