Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #387

Closed
wants to merge 4 commits into from
Closed

Fix build #387

wants to merge 4 commits into from

Commits on Nov 28, 2023

  1. fix(linalg3): linkage conflict for fabs() 

    Seems like extern fabs() in linalg3.pyx is assumed to have c++ linkage as linalg3.cpp file is generated. However, this fabs() ends up conflicting with the declaration with c linkage from /usr/include/x86_64-linux-gnu/bits/mathcalls.h on ubuntu github actions runner.
    @nauaneed
    nauaneed committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3cbec65 View commit details
    Browse the repository at this point in the history

  2. fix(NNPSs): fmax() and fmin() conflict 

    Builds were failing on windows github actions runner due to some
conflict involving fmax() and fmin().

Seems like  fmax() and fmin() were defined soleley for windows as
they are a part of C99 standard but earlier MSVC not support C99
features fully. But now, MSVC supports it. So, it is no longer required.
    @nauaneed
    nauaneed committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    221dfbd View commit details
    Browse the repository at this point in the history

  3. ci(tests): run tests on python 3.11

    @nauaneed
    nauaneed committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7250514 View commit details
    Browse the repository at this point in the history

  4. ci(zoltan-tests): use latest cyarray from github 

    not from pypi
    @nauaneed
    nauaneed committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    51015d1 View commit details
    Browse the repository at this point in the history