Fixed issue within Snapshot.py
where the memory_viz_version
parameter was not respected
#1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
_The
test_snapshot_save_create_svg
test was failing due to an issue insnapshot_save_file.py
. The script attempted to specify a version number for the Memory Viz library, but this argument was not being respected. This led to a file_path error because the tests were passing directories as the output path to the memory-viz CLI, which is no longer accepted in the new version.To resolve this issue, I modified
snapshot.py
to ensure the correct handling of the output path and version specification._...
Type of Change
Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)