Defer loading of importtlib.metadata #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package is needed for `load_setuptools_entrypoints`, but it is quite slow to import. While most users do use `load_setuptools_entrypoints`, maybe some don't, so let's let them avoid the cost. For `import pluggy`: Before: 36ms After: 11ms
|
Is the failure related to the current change? |
RonnyPfannschmidt
approved these changes
Dec 26, 2023
|
we should apply https://hynek.me/articles/ditch-codecov-python/ by grace of @hynek to be free |
|
We do have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #445 (comment)
This package is needed for
load_setuptools_entrypoints, but it is quite slow to import. While most users do useload_setuptools_entrypoints, maybe some don't, so let's let them avoid the cost.For
import pluggy:Before: 36ms
After: 11ms