Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing tests for trait and maybe #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MRigal
Copy link

@MRigal MRigal commented Jun 24, 2021

The failing tests in test_maybe_trait will fail with all factoryboy versions, but has minor consequences, as there is an obvious work-around. They may rely completely inside factory-boy itself, see this PR

The test failing with test_circular with Trait as Params fails with Version 3.2 and this PR with massive consequences, as factory.Maybe does not have a call() Method anymore. This failure is harder, as it fails at register, where the Maybe Class is passed to make_deferred_postgen

@MRigal MRigal force-pushed the testing_traits_and_maybes branch from d2c1ca1 to b8f310a Compare June 25, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant