feat: switch to wormhole p2p #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmzlt
reviewed
Nov 6, 2023
| "github.com/libp2p/go-libp2p" | ||
| dht "github.com/libp2p/go-libp2p-kad-dht" | ||
| pubsub "github.com/libp2p/go-libp2p-pubsub" | ||
| "github.com/certusone/wormhole/node/pkg/supervisor" |
There was a problem hiding this comment.
Do we really need this supervisor thing? I'm probably wrong, but I remember it being related to that old disconnect bug in the spy.
There was a problem hiding this comment.
Unfortunately it seems impossible to run the p2p code without supervisor. It gets supervisor stuff from the context on p2p.Run method.
thmzlt
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the receiver from plain p2p to use Wormhole p2p package. Most of the code is adopted from Wormhole spy code.
Wormhole is going to switch to another version of QUIC and they have implemented the transition in their code base. They are going to do the switch for testnet tomorrow and we need to ship the new version out before the transition time, otherwise our beacons will fail on testnet.
I will switch to zap for logging later. I think it will be cleaner to do in a subsequent PR. The supervisor logs are not very noisy at the moment.
wormhole-foundation/wormhole#3463