Resize accounts #241
Merged
Resize accounts #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guibescos
force-pushed
the
resize-accounts
branch
from
13bf4ec
to
c06b199
Compare
guibescos
changed the base branch from
main
to
frontend/handle-closing-unlocked-positions
Base automatically changed from
frontend/handle-closing-unlocked-positions
to
main
September 21, 2023 16:15
guibescos
force-pushed
the
resize-accounts
branch
from
c06b199
to
f32193c
Compare
guibescos
force-pushed
the
resize-accounts
branch
2 times, most recently
from
94488bc
to
b017a55
Compare
guibescos
force-pushed
the
resize-accounts
branch
from
c2401ed
to
f32193c
Compare
guibescos
force-pushed
the
resize-accounts
branch
from
ba8cf56
to
2dcde98
Compare
guibescos
commented
Sep 21, 2023
| @@ -17,8 +17,7 @@ jobs: | |||
| with: | |||
| node-version: "16.13" | |||
| - name: Npm install | |||
| working-directory: ./staking | |||
| run: npm install | |||
| run: npm ci | |||
There was a problem hiding this comment.
drive-by use npm ci
guibescos
commented
Sep 21, 2023
package-lock.json
Outdated
There was a problem hiding this comment.
drive-by clean up package lock
guibescos
commented
Sep 21, 2023
| @@ -417,7 +419,8 @@ pub mod tests { | |||
| position_data.write_position(i, &position).unwrap(); | |||
| } else { | |||
| assert!(set.len() == MAX_POSITIONS); | |||
| assert!(position_data.reserve_new_index(&mut next_index).is_err()) | |||
| assert!(position_data.reserve_new_index(&mut next_index).is_err()); | |||
| next_index -= 1; | |||
There was a problem hiding this comment.
drive-by fix this test
jayantk
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resize user accounts to be smaller.
The position account goes from 100 positions to 20 positions.
The cost of a stake account goes from 0.22 SOL to 0.038 SOL.