Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llc agreement #249

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Add llc agreement #249

merged 9 commits into from
Oct 24, 2023

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Oct 23, 2023

Adds an intruction join_dao_lcc where the user needs to sign a hash of the DAO LLC agreement.
This agreement needs to be signed before the user is able to vote or stake.

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 3:26pm
staking-devnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 3:26pm

Copy link
Collaborator

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

staking/programs/staking/src/lib.rs Outdated Show resolved Hide resolved
@@ -708,6 +734,10 @@ export class StakeConnection {
);
}

if (!stakeAccount || !this.isLlcMember(stakeAccount)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like there's a block of code above this that's duplicated a few times. consider extracting out a helper method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants