Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approval page & fix split request accept thing #267

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

jayantk
Copy link
Collaborator

@jayantk jayantk commented Nov 13, 2023

The webpage is janky but whatever, it's just for PDA anyway.

Copy link

vercel bot commented Nov 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 11:55pm
staking-devnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 11:55pm

@cctdaniel
Copy link
Contributor

sorry can I have more context here?

  • what is the purpose of this page?
  • is this page supposed to be "hidden" (e.g. only accessible through the url directly)
  • im getting an Uncaught TypeError when clicking on the approve button (is this expected?)
  • are we ok with the page looking wanky? or do you need me to make it look basically presentable?

@guibescos
Copy link
Contributor

The purpose of this page is for PDA for be able to authorize transfers of locked (unvested) tokens. It's hidden and only for internal use.

@guibescos guibescos merged commit b59be91 into main Nov 14, 2023
8 checks passed
@guibescos guibescos deleted the approve_split branch November 14, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants